New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump gcal_sync to 0.6.2 and switch to google calendar async iterator api #70616
Merged
allenporter
merged 5 commits into
home-assistant:dev
from
allenporter:calendar-async-iterator
Apr 27, 2022
Merged
Bump gcal_sync to 0.6.2 and switch to google calendar async iterator api #70616
allenporter
merged 5 commits into
home-assistant:dev
from
allenporter:calendar-async-iterator
Apr 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
code-quality
dependency
integration: google
small-pr
PRs with less than 30 lines.
by-code-owner
labels
Apr 25, 2022
allenporter
force-pushed
the
calendar-async-iterator
branch
from
April 25, 2022 14:53
d9e8a39
to
d797ae3
Compare
In draft while I figure out this error (doesn't happen in my py 3.9. tests, but happens here)
|
I think you need to use |
allenporter
changed the title
Bump gcal_sync to 0.6.0 and switch to google calendar async iterator api
Bump gcal_sync to 0.6.1 and switch to google calendar async iterator api
Apr 27, 2022
allenporter
force-pushed
the
calendar-async-iterator
branch
from
April 27, 2022 04:55
916220f
to
da69942
Compare
allenporter
changed the title
Bump gcal_sync to 0.6.1 and switch to google calendar async iterator api
Bump gcal_sync to 0.6.2 and switch to google calendar async iterator api
Apr 27, 2022
allenporter
force-pushed
the
calendar-async-iterator
branch
from
April 27, 2022 05:37
da69942
to
12ee9fd
Compare
balloob
approved these changes
Apr 27, 2022
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
allenporter
force-pushed
the
calendar-async-iterator
branch
from
April 27, 2022 06:29
12ee9fd
to
b3706fb
Compare
MartinHjelmare
approved these changes
Apr 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cla-signed
code-quality
dependency
integration: google
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Update google calendar to use a new async iterator api when paging through events, a followup discussed in #70173
Diff: allenporter/gcal_sync@0.5.0...0.6.2
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: