New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add state buffering to media_player and use it in cast #70802
Conversation
@@ -323,6 +323,7 @@ class Platform(StrEnum): | |||
STATE_OPENING: Final = "opening" | |||
STATE_CLOSED: Final = "closed" | |||
STATE_CLOSING: Final = "closing" | |||
STATE_BUFFERING: Final = "buffering" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
media player could use a state enum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, but lets keep it out of scope for this PR :)
ef0aeb6
to
412e9b6
Compare
@@ -323,6 +323,7 @@ class Platform(StrEnum): | |||
STATE_OPENING: Final = "opening" | |||
STATE_CLOSED: Final = "closed" | |||
STATE_CLOSING: Final = "closing" | |||
STATE_BUFFERING: Final = "buffering" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need a new translation string, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point 馃憤
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And device automations may need to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And reproduce state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translations added here: #70856
Proposed change
Add state
buffering
as proposed in home-assistant/architecture#763 and use it incast
media player.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: