Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail recorder setup with unsupported dialect or version #70888

Merged
merged 1 commit into from May 18, 2022

Conversation

emontnemery
Copy link
Contributor

Breaking change

The recorder now fails to setup if the database dialect is unsupported, or if the database dialect is supported but the version is too old (ADR18).

Proposed change

This is a follow-up to #58161, which added a warning if the database dialect is unsupported or outdated.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@emontnemery
Copy link
Contributor Author

Tests fail because the SQLite version in the container is very old, I'm not quite sure what to do about that.
It seems a bit unreasonable to run tests against a version we don't support?

@frenck
Copy link
Member

frenck commented Apr 28, 2022

We need to upgrade our testing containers from Debian Buster to Debian Bulleye
Ref: https://github.com/home-assistant/ci-azure/blob/master/python/Dockerfile-3.9#L1

@emontnemery emontnemery force-pushed the recorder_fail_unsupported_dialect branch from 4a604c8 to ab07116 Compare May 18, 2022 13:58
@emontnemery
Copy link
Contributor Author

CI upgraded to use Debian Bullseye thanks to home-assistant/ci-azure#21

@emontnemery emontnemery merged commit 037f694 into dev May 18, 2022
@emontnemery emontnemery deleted the recorder_fail_unsupported_dialect branch May 18, 2022 14:52
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants