Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New KinCony Hx component #70908

Closed
wants to merge 1 commit into from

Conversation

kgkolev
Copy link

@kgkolev kgkolev commented Apr 27, 2022

Proposed change

This is a best-effort unification and harmonization of various approaches for integrating a KinCony H8/16/32 boards in a more native HASS component way for easier consumption by the general public. It should be considered as a functional code, but not a fully polished (unit tested, community tested, documented, branded, etc) integration as it is not of direct value to me at this time.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Background user issues observed:

Existing approaches for integration:

Out of scope changes/PRs:

  • KinCony PyPi library not planned/included
  • Test Cases not planned/included
  • Documentation not planned/included
  • Logos/Branding not planned/included

Checklist

  • The code change is tested and works locally. - using KinCony KC868-H32 Board
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist - All but the pypi Library
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Documentation added/updated for www.home-assistant.io - ** Doc page not added **
  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@thecode
Copy link
Member

thecode commented Apr 30, 2022

Hi @kgkolev,
I highly recommend to Set up Development Environment your PR is missing tests, requirements which are mandatory for it to be accepted. I also recommend going through the steps in Creating your first integration.

Thanks 👍

@kgkolev kgkolev marked this pull request as draft May 5, 2022 08:04
@kgkolev
Copy link
Author

kgkolev commented May 5, 2022

Thanks @thecode, will add at some point and put the PR back for review. Any further input or advice in the interim is appreciated. Thanks!

@MartinHjelmare MartinHjelmare added this to Incoming in Dev Jun 26, 2022
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 3, 2022
@github-actions github-actions bot closed this Aug 10, 2022
Dev automation moved this from Incoming to Cancelled Aug 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Cancelled
Development

Successfully merging this pull request may close these issues.

None yet

3 participants