Ensure that email-based 2FA in SimpliSafe shows the progress UI #71021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachya
commented
Apr 28, 2022
| ) | ||
|
|
||
| return await self._async_finish_setup() | ||
| try: | ||
| await self._email_2fa_task |
There was a problem hiding this comment.
One curiosity I have: is there a way to detect if the user hits the X button in the UI? If so, I'd love to cancel this task, as there's no point in continuing a 5-minute run if the user gives up.
There was a problem hiding this comment.
I don't know that we have that kind of life cycle hook yet. I'd ask in Discord if someone knows more or has an idea.
There was a problem hiding this comment.
We currently don't have that, but we can add that by adding a hook here: https://github.com/home-assistant/core/blob/dev/homeassistant/data_entry_flow.py#L307
bachya
changed the title
|
Coverage CI failure is not related to this PR. |
balloob
approved these changes
Apr 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Based on @MartinHjelmare's suggestion in #70160, this PR utilizes the progress UI during the email-based Simplisafe 2FA flow.
Unfortunately, I've migrated my SimpliSafe account to SMS-based 2FA and there's no way to revert, so I'm flying a bit blind on this one.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: