Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PECO smart meter binary_sensor #71034

Merged
merged 15 commits into from Nov 29, 2023

Conversation

IceBotYT
Copy link
Contributor

@IceBotYT IceBotYT commented Apr 29, 2022

Proposed change

Add support for smart meter functionality, which verifies if your meter is receiving power or not.
This is the same implementation as the website here

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@gjohansson-ST
Copy link
Member

It would seem to me the user gets one or the other. Why not adding both

@IceBotYT
Copy link
Contributor Author

Why not adding both

It is simpler for users because the meter check takes a while. Users can always go to the config flow again to add a outage counter or another smart meter.

@IceBotYT IceBotYT mentioned this pull request Jun 14, 2022
22 tasks
@MartinHjelmare MartinHjelmare added this to By Code Owner in Dev Jun 26, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 12, 2022
@IceBotYT
Copy link
Contributor Author

Not stale..

@gjohansson-ST
Copy link
Member

Setting as draft until conflicts resolved

@gjohansson-ST gjohansson-ST marked this pull request as draft May 13, 2023 10:19
@IceBotYT IceBotYT marked this pull request as ready for review May 26, 2023 00:03
@IceBotYT IceBotYT marked this pull request as draft May 26, 2023 15:41
@IceBotYT IceBotYT marked this pull request as ready for review May 26, 2023 16:10
@IceBotYT IceBotYT force-pushed the peco-smart-meter branch 2 times, most recently from ddd3296 to 3cb8305 Compare May 28, 2023 16:42
@emontnemery
Copy link
Contributor

@IceBotYT to be clear, this PR won't be merged with the sleep hiding a problem with the progress. If you can't work it out yourself, please contact me on Discord and we can solve it together.
I'm @emontnemery also on Discord.

@emontnemery
Copy link
Contributor

PECO needs updates to the branding (for a separate PR though):
image

  • The "Peco Outage Counter" and "PECO Energy Company (PECO)" integrations should co collected under a "PECO Energy Company" brand
    • I believe this will also solve the missing brand image for "Peco Outage Counter"
  • The name of "PECO Energy Company (PECO)" integration should be improved to explain what it provides compared to the outage counter integration

homeassistant/components/peco/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/peco/strings.json Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 27, 2023 10:15
@IceBotYT IceBotYT marked this pull request as ready for review November 28, 2023 21:41
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @IceBotYT 👍

Dev automation moved this from Review in progress to Reviewer approved Nov 29, 2023
@emontnemery emontnemery merged commit 526180a into home-assistant:dev Nov 29, 2023
23 checks passed
Dev automation moved this from Reviewer approved to Done Nov 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
@emontnemery
Copy link
Contributor

Temporarily reverted by #105222

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants