Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importing blueprints #71365

Merged
merged 4 commits into from May 5, 2022
Merged

Fix importing blueprints #71365

merged 4 commits into from May 5, 2022

Conversation

balloob
Copy link
Member

@balloob balloob commented May 5, 2022

Breaking change

Proposed change

Inputs using selectors failed to import. This fixes it by allowing selectors to be serialized to YAML.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@balloob balloob added this to the 2022.5.1 milestone May 5, 2022
@balloob balloob requested a review from a team as a code owner May 5, 2022 19:16
@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (blueprint) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@balloob
Copy link
Member Author

balloob commented May 5, 2022

meh, somehow this doesn't work yet in the frontend while test passes.

@balloob
Copy link
Member Author

balloob commented May 5, 2022

Works now 馃憤

Co-authored-by: Shay Levy <levyshay1@gmail.com>
@balloob balloob merged commit 353cc0b into dev May 5, 2022
@balloob balloob deleted the fix-blueprint-import branch May 5, 2022 21:33
balloob added a commit that referenced this pull request May 5, 2022
Co-authored-by: Shay Levy <levyshay1@gmail.com>
@balloob balloob mentioned this pull request May 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants