New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if requirements are installed in the executor #71611
Check if requirements are installed in the executor #71611
Conversation
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Still need to get back to this |
Too many irons in the fire this month |
Retest looks good. Less I/O starvation at startup. This won't address the CPU being bound on the GIL issues at startup, but making all that better is slow grinding incremental process. We will never be able to fix the problem where we have to load python files from disk in the event loop though as there are so many packages that make assumptions that they are loaded in the thread the event loop is running. We could make that better with a limit to how many we load at the same time but the tradeoff is slower startup |
Proposed change
May help with #71575
pkg_util.is_installed
does I/O, it should run in the executorThis got rid of many more asyncio warnings when a component was discovered or startup was happening on a slow disk
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: