Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move manual configuration of MQTT alarm control panel to the integration key #72165

Merged

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented May 19, 2022

Breaking change

This is an addition to #71676 and adds the alarm_control_panel platform

Proposed change

Move manual configuration of MQTT alarm control panel to the integration key

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev May 19, 2022
@MartinHjelmare MartinHjelmare changed the title Move manual configuration of MQTT fan and light to the integration key Move manual configuration of MQTT alarm control panel to the integration key May 19, 2022
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jbouwh

Dev automation moved this from Needs review to Reviewer approved May 19, 2022
@emontnemery emontnemery merged commit 654b095 into home-assistant:dev May 20, 2022
Dev automation moved this from Reviewer approved to Done May 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2022
@jbouwh jbouwh deleted the mqtt-manual-setup-alarm_control_panel branch May 21, 2022 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants