Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust config-flow type hints in vera #72409

Merged
merged 2 commits into from Jun 7, 2022

Conversation

epenet
Copy link
Contributor

@epenet epenet commented May 24, 2022

Proposed change

Needed for #72834

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @pavoni, mind taking a look at this pull request as it has been labeled with an integration (vera) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev May 24, 2022
@pavoni
Copy link
Contributor

pavoni commented May 24, 2022

@epenet Do you have a particular interest in Vera - or are you more generally doing some HA tiding up?

If the former would you be interesting in taking over ownership? I no longer have a live vera hub...

@epenet
Copy link
Contributor Author

epenet commented May 24, 2022

@epenet Do you have a particular interest in Vera - or are you more generally doing some HA tiding up?

If the former would you be interesting in taking over ownership? I no longer have a live vera hub...

Just doing some tidy up

@epenet epenet added the smash Indicator this PR is close to finish for merging or closing label Jun 7, 2022
@epenet
Copy link
Contributor Author

epenet commented Jun 7, 2022

I reduced the size of the PR to only include type-hint changes.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Dev automation moved this from Needs review to Reviewer approved Jun 7, 2022
@MartinHjelmare MartinHjelmare merged commit 6971bb8 into dev Jun 7, 2022
Dev automation moved this from Reviewer approved to Done Jun 7, 2022
@MartinHjelmare MartinHjelmare deleted the epenet-config-flow-type-hints-vera branch June 7, 2022 09:15
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality integration: vera smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants