Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recorder: Check for ENTITY_ID key that contains None value #7287

Merged
merged 1 commit into from Apr 25, 2017
Merged

Recorder: Check for ENTITY_ID key that contains None value #7287

merged 1 commit into from Apr 25, 2017

Conversation

balloob
Copy link
Member

@balloob balloob commented Apr 25, 2017 •
edited

Description:

Fix a bug reported by @dale3h: Sometimes an event is sent that contains the key entity_id but the value is None. This was tripping the recorder.

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.43.1 milestone Apr 25, 2017
@mention-bot
Copy link

@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rhooper, @kellerza and @mjg59 to be potential reviewers.

dale3h
dale3h approved these changes Apr 25, 2017
View reviewed changes
Copy link
Member

@dale3h dale3h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎃

@dale3h dale3h added the bug label Apr 25, 2017
@balloob balloob merged commit 335362f into dev Apr 25, 2017
@balloob balloob deleted the recorder-none-check branch April 25, 2017 03:51
balloob added a commit that referenced this pull request Apr 25, 2017
@balloob
Recorder: Check for ENTITY_ID key that contains None value (#7287)
166bcc0
@balloob balloob mentioned this pull request Apr 25, 2017
Merged
@balloob balloob mentioned this pull request May 5, 2017
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dale3h dale3h dale3h approved these changes

Assignees
No one assigned
Labels
bug cla-signed integration: recorder
Projects
None yet
Milestone
0.43.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@balloob @mention-bot @dale3h @homeassistant