Bump wallbox to 0.4.9 #72978
Bump wallbox to 0.4.9 #72978
Conversation
probot-home-assistant
bot
added
bugfix
integration: wallbox
small-pr
|
@frenck @cdce8p very small change, we need to update the wallbox package dependency to prevent future issues. I hope one of you has time to give this a quick check. I want to prevent an issue in the future by changing the version now. I have tested the new dependency locally and everything works fine with this new version. |
epenet
changed the title
|
Noticed to late that my tests needed updating after the version bump (which I, looking at the tests, should have thought about earlier ;-)) |
|
tests are still failing, but I think this is another issue? |
| @@ -47,7 +29,7 @@ async def test_wallbox_lock_class(hass: HomeAssistant) -> None: | |||
|
|
|||
| with requests_mock.Mocker() as mock_request: | |||
| mock_request.get( | |||
| "https://api.wall-box.com/auth/token/user", | |||
| "https://user-api.wall-box.com/users/signin", | |||
There was a problem hiding this comment.
It would be better if the tests mocked the library instead and have the tests in the library test the endpoints.
Ideally Home Assistant doesn't know anything about the endpoints that the library uses
| "ssdp": [], | ||
| "zeroconf": [], | ||
| "homekit": {}, |
There was a problem hiding this comment.
In a future PR, you can remove empty fields
| "ssdp": [], | |
| "zeroconf": [], | |
| "homekit": {}, |
Proposed change
I have updated the manifest.json to use a newer version of the pypi wallbox package. This is triggered by a request from @victor-falcon, who indicates that Wallbox has changed the auth part of its API (the old auth will stop working soon). This is thus needed to prevent future issues.
This is the upstream change:
cliviu74/wallbox@9ea6f11
Release notes: https://github.com/cliviu74/wallbox/releases/tag/0.4.9
Full compare: cliviu74/wallbox@0.4.4...0.4.9
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: