Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing historical context data in logbook for MySQL and PostgreSQL #73011

Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 4, 2022

Proposed change

  • sqlalchemy's JSON implementation always wraps the result in JSON_QUOTE
    for text, but when matching on MySQL or PostgreSQL we need to check
    for NULL

Only happens when you set up a logbook and/or recorder filter.

Found while working on #72963

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

- sqlalchemy JSON implementation always wraps the result in JSON_QUOTE
  for text, but when matching on MySQL or PostgreSQL we need to check
  for NULL
@bdraco bdraco added this to the 2022.6.2 milestone Jun 4, 2022
@bdraco bdraco requested a review from a team as a code owner June 4, 2022 04:51
@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco marked this pull request as draft June 4, 2022 05:00
@bdraco

This comment was marked as outdated.

@bdraco bdraco marked this pull request as ready for review June 4, 2022 06:06
@balloob balloob merged commit 7ac7af0 into home-assistant:dev Jun 4, 2022
@balloob balloob mentioned this pull request Jun 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants