Tomorrowio utc fix #73102
Merged
Tomorrowio utc fix #73102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
bugfix
integration: tomorrowio
small-pr
|
Hey there @raman325, mind taking a look at this pull request as it has been labeled with an integration ( |
bdraco
reviewed
Jun 6, 2022
Comment on lines
214
to
216
| # Throw out past data | ||
| if forecast_dt.date() < dt_util.utcnow().date(): | ||
| if dt_util.as_local(forecast_dt).date() < today: | ||
| continue |
There was a problem hiding this comment.
AFAICT, there is no guarantee that the data is for the same time zone as the instance's configured timezone. I expect you might want data for a location that isn't your home.
It would be a better check to throw out data that is X hours older than now instead of in the previous day.
There was a problem hiding this comment.
I think this fix is fine for now though as it should solve the most common case.
balloob
pushed a commit
that referenced
this pull request
Jun 6, 2022
* Discard past data using local time instead of UTC * Tweak changes to fix tests * Cleanup
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Bug fix for #73080
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: