Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostic sensors for TotalConnect #73152

Merged

Conversation

austinmroczek
Copy link
Contributor

@austinmroczek austinmroczek commented Jun 7, 2022

Breaking change

Users previously relying on the zone attributes for tampered and low_battery status must now use the new diagnostic binary sensors.

Proposed change

Adds diagnostic sensors for zone low battery and tampered status. Adds diagnostic sensors for alarm panel low battery, tampered and power status.

Add tests for binary_sensor.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 12, 2022
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments to improve

@MartinHjelmare MartinHjelmare added this to By Code Owner in Dev Jun 26, 2022
@frenck frenck added smash Indicator this PR is close to finish for merging or closing and removed smash Indicator this PR is close to finish for merging or closing labels Jun 28, 2022
@frenck
Copy link
Member

frenck commented Sep 28, 2022

@austinmroczek There is a merge conflict, could you take a look?

Thanks! 馃憤

../Frenck

@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Sep 28, 2022
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Dec 21, 2022
@austinmroczek austinmroczek force-pushed the tcc_diagnostic_sensors branch 2 times, most recently from b858600 to 32c222c Compare February 24, 2023 17:03
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small details left then it should be set I think

homeassistant/components/totalconnect/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/totalconnect/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/totalconnect/binary_sensor.py Outdated Show resolved Hide resolved
tests/components/totalconnect/test_binary_sensor.py Outdated Show resolved Hide resolved
Dev automation moved this from By Code Owner to Review in progress May 6, 2023
@home-assistant home-assistant bot marked this pull request as draft May 6, 2023 18:29
@home-assistant
Copy link

home-assistant bot commented May 6, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 馃憤

Learn more about our pull request process.

austinmroczek and others added 2 commits May 6, 2023 15:33
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
@austinmroczek austinmroczek marked this pull request as ready for review May 6, 2023 22:58
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

Dev automation moved this from Review in progress to Reviewer approved May 7, 2023
@gjohansson-ST gjohansson-ST merged commit 16c9158 into home-assistant:dev May 7, 2023
24 checks passed
Dev automation moved this from Reviewer approved to Done May 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2023
@austinmroczek austinmroczek deleted the tcc_diagnostic_sensors branch April 21, 2024 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants