New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagnostic sensors for TotalConnect #73152
Add diagnostic sensors for TotalConnect #73152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments to improve
@austinmroczek There is a merge conflict, could you take a look? Thanks! 馃憤 ../Frenck |
b858600
to
32c222c
Compare
This reverts commit 9808d73.
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
19808b4
to
35a31c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small details left then it should be set I think
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 馃憤 |
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 馃憤
Breaking change
Users previously relying on the zone attributes for tampered and low_battery status must now use the new diagnostic binary sensors.
Proposed change
Adds diagnostic sensors for zone low battery and tampered status. Adds diagnostic sensors for alarm panel low battery, tampered and power status.
Add tests for binary_sensor.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: