Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MQTT reload performance #73313

Merged
merged 4 commits into from Jun 10, 2022
Merged

Improve MQTT reload performance #73313

merged 4 commits into from Jun 10, 2022

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Jun 10, 2022

Proposed change

Improve MQTT reload performance by only sourcing yaml once

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

homeassistant/components/mqtt/mixins.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/__init__.py Outdated Show resolved Hide resolved
@emontnemery emontnemery added this to the 2022.6.5 milestone Jun 10, 2022
emontnemery and others added 3 commits June 10, 2022 13:06
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Dev automation moved this from By Code Owner to Reviewer approved Jun 10, 2022
@emontnemery emontnemery merged commit de2fade into dev Jun 10, 2022
Dev automation moved this from Reviewer approved to Done Jun 10, 2022
@emontnemery emontnemery deleted the mqtt_improve_reload branch June 10, 2022 12:23
balloob pushed a commit that referenced this pull request Jun 10, 2022
* Improve MQTT reload performance

* Update homeassistant/components/mqtt/__init__.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Update homeassistant/components/mqtt/mixins.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Update homeassistant/components/mqtt/__init__.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@balloob balloob mentioned this pull request Jun 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Reload MQTT entities takes down system
4 participants