Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse limitlessled color_temp range #7359

Merged
merged 1 commit into from
May 3, 2017

Conversation

amelchio
Copy link
Contributor

@amelchio amelchio commented Apr 29, 2017

Description:

I do not have this hardware but the limitlessled range apparently goes from 0.0 (warm) to 1.0 (cold).

This is a somewhat breaking change because existing color_temp configurations will have to be changed (into 500-old_value).

Related issue (if applicable): fixes #7333

Notice for release notes: The LimitlessLED color temperatures have been turned around to work like other lights. To maintain previous colors you must adjust the color_temp value in your light.turn_on calls to 654 minus your old value (for example, 280 becomes 374).

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully.

@mention-bot
Copy link

@amelchio, thanks for your PR! By analyzing the history of the files in this pull request, we identified @happyleavesaoc, @fabaff and @Azelphur to be potential reviewers.

@amelchio
Copy link
Contributor Author

It appears that this is better, but still wrong.

I found some documentation and it suggests that the valid range is 2700K-6500K.

So the conversion could be further improved if #7206 is merged.

@balloob
Copy link
Member

balloob commented Apr 30, 2017

You're the color temperature master, so merge when you think it's ok.

Could you add a 1 line description to the PR description about the breaking change for the release notes ?

@amelchio
Copy link
Contributor Author

amelchio commented May 1, 2017

@happyleavesaoc What do you think of this change?

@happyleavesaoc
Copy link
Contributor

@amelchio This should work.

@amelchio amelchio changed the title [WIP] Reverse limitlessled color_temp range Reverse limitlessled color_temp range May 3, 2017
@amelchio amelchio merged commit dbd6f7e into home-assistant:dev May 3, 2017
@balloob balloob mentioned this pull request May 5, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants