New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up zha tests #73627
Speed up zha tests #73627
Conversation
- Only setup the platforms each test is testing
Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution. Seems likely other integrations could benefit from something like this.
We did the same for mqtt already. I think any integration that loads all the platforms can be sped up in this manner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 馃憤 looks good
Thanks 馃憤 |
Proposed change
test_discovery didn't get this speedup since each test's PLATFORMs
would need to be patched for what it discovered and that would
make this change much larger. Doing so would likely shave at
least another minute of the tests
Before Results (274.96s)
After Results (189.37s)
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: