Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up zha tests #73627

Merged
merged 3 commits into from Jun 17, 2022
Merged

Speed up zha tests #73627

merged 3 commits into from Jun 17, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 17, 2022

Proposed change

  • Only setup the platforms each test is testing

test_discovery didn't get this speedup since each test's PLATFORMs
would need to be patched for what it discovered and that would
make this change much larger. Doing so would likely shave at
least another minute of the tests

Before Results (274.96s)
After Results (189.37s)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

- Only setup the platforms each test is testing
@probot-home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco marked this pull request as ready for review June 17, 2022 07:56
Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution. Seems likely other integrations could benefit from something like this.

@bdraco
Copy link
Member Author

bdraco commented Jun 17, 2022

We did the same for mqtt already. I think any integration that loads all the platforms can be sped up in this manner.

Copy link
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 馃憤 looks good

@bdraco
Copy link
Member Author

bdraco commented Jun 17, 2022

Thanks 馃憤

@bdraco bdraco merged commit 4bc5d7b into home-assistant:dev Jun 17, 2022
@bdraco bdraco deleted the zha_test_speed branch June 17, 2022 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants