New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for DD in time_period_str #73693
Conversation
c681cdf
to
972598d
Compare
I'm not sure why 3.9(2) fails but 3.10(2) passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this adjusts core functionality, it would needs tests to verify its functionality.
Additionally, open up a PR to adjust the Home Assistant documentation and link it up with this PR.
Do you mind pointing me in the direction of the relevant Home Assistant documentation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation repository can be found here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure the tests pass :)
All of these failed tests are stemming from this comment. I can modify all the tests to go from Tests pass on d9bef40... |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
This PR seems to went stale, going to close for that reason. Feel free to re-open when you are ready to work on it again |
Proposed change
Allow for strings containing "DD" piece. Helpful for data structures such as DRF DurationField.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: