Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for DD in time_period_str #73693

Closed
wants to merge 4 commits into from

Conversation

jcgoette
Copy link

@jcgoette jcgoette commented Jun 19, 2022

Proposed change

Allow for strings containing "DD" piece. Helpful for data structures such as DRF DurationField.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@jcgoette
Copy link
Author

I'm not sure why 3.9(2) fails but 3.10(2) passes.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this adjusts core functionality, it would needs tests to verify its functionality.

Additionally, open up a PR to adjust the Home Assistant documentation and link it up with this PR.

homeassistant/helpers/config_validation.py Outdated Show resolved Hide resolved
homeassistant/helpers/config_validation.py Outdated Show resolved Hide resolved
@MartinHjelmare MartinHjelmare added this to Review in progress in Dev Jun 26, 2022
@jcgoette
Copy link
Author

jcgoette commented Jul 1, 2022

Do you mind pointing me in the direction of the relevant Home Assistant documentation?

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation repository can be found here:

https://github.com/home-assistant/home-assistant.io

tests/helpers/test_config_validation.py Outdated Show resolved Hide resolved
tests/helpers/test_config_validation.py Outdated Show resolved Hide resolved
@jcgoette jcgoette requested a review from frenck July 13, 2022 14:26
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 25, 2022
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Sep 28, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the tests pass :)

@jcgoette
Copy link
Author

Please make sure the tests pass :)

All of these failed tests are stemming from this comment.

I can modify all the tests to go from HH:MM to HH:MM:SS format, but I don't think that's the right answer.

Tests pass on d9bef40...

@frenck frenck self-requested a review December 20, 2022 23:48
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 21, 2023
@edenhaus
Copy link
Contributor

edenhaus commented Aug 8, 2023

This PR seems to went stale, going to close for that reason. Feel free to re-open when you are ready to work on it again

@edenhaus edenhaus closed this Aug 8, 2023
Dev automation moved this from Review in progress to Cancelled Aug 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Cancelled
Development

Successfully merging this pull request may close these issues.

None yet

4 participants