Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Atlantic Electrical Towel Dryer to Overkiz integration #73788

Merged

Conversation

iMicknl
Copy link
Contributor

@iMicknl iMicknl commented Jun 21, 2022

Proposed change

Part of the efforts to support all Overkiz climate devices. This time the Atlantic Electrical Towel Dryer, ported from the custom component to core.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jun 21, 2022
@tetienne
Copy link
Contributor

One less to migrate 馃憤

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 22, 2022
Dev automation moved this from By Code Owner to Reviewer approved Jun 28, 2022
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. Seems there is a lot of overlap among the climate entities. Can this be generalized? (in a future PR)

@balloob balloob merged commit a284ebe into home-assistant:dev Jun 28, 2022
Dev automation moved this from Reviewer approved to Done Jun 28, 2022
@iMicknl
Copy link
Contributor Author

iMicknl commented Jun 28, 2022

This is fine. Seems there is a lot of overlap among the climate entities. Can this be generalized? (in a future PR)

@balloob I am happy to generalize this, but tbh I had no clue. I looked at our custom component (https://github.com/iMicknl/ha-tahoma/tree/master/custom_components/tahoma/climate_devices) and it seemed that there was not a good way to rewrite all climate devices to entity descriptions.

For cover, we will move to entity descriptions soon since we figured out all models. However for climate, there is a lot of (weird) logic required per model, where I don't see how I can generalize this. If you have any tips / best practices to share; I would be happy to implement this. (especially to avoid having 20 climate classes in the end..)

@tetienne tetienne deleted the overkiz/atlantic_eletrical_towel_dryer branch June 29, 2022 06:58
@tetienne
Copy link
Contributor

Well, if we really want to generalize some pattern, one candidate would be the linked_temperature_device, but not all climate devices would use it, and we can also move the temperature unit in a parent class, they all are Celcius.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed integration: overkiz new-feature smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants