New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Atlantic Electrical Towel Dryer to Overkiz integration #73788
Add support for Atlantic Electrical Towel Dryer to Overkiz integration #73788
Conversation
Hey there @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration ( |
homeassistant/components/overkiz/climate_entities/atlantic_electrical_towel_dryer.py
Outdated
Show resolved
Hide resolved
homeassistant/components/overkiz/climate_entities/atlantic_electrical_towel_dryer.py
Show resolved
Hide resolved
homeassistant/components/overkiz/climate_entities/atlantic_electrical_towel_dryer.py
Show resolved
Hide resolved
One less to migrate 馃憤 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine. Seems there is a lot of overlap among the climate entities. Can this be generalized? (in a future PR)
@balloob I am happy to generalize this, but tbh I had no clue. I looked at our custom component (https://github.com/iMicknl/ha-tahoma/tree/master/custom_components/tahoma/climate_devices) and it seemed that there was not a good way to rewrite all climate devices to entity descriptions. For cover, we will move to entity descriptions soon since we figured out all models. However for climate, there is a lot of (weird) logic required per model, where I don't see how I can generalize this. If you have any tips / best practices to share; I would be happy to implement this. (especially to avoid having 20 climate classes in the end..) |
Well, if we really want to generalize some pattern, one candidate would be the linked_temperature_device, but not all climate devices would use it, and we can also move the temperature unit in a parent class, they all are Celcius. |
Proposed change
Part of the efforts to support all Overkiz climate devices. This time the Atlantic Electrical Towel Dryer, ported from the custom component to core.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: