Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially revert "Switch loader to use json helper (#73872)" #74077

Merged
merged 2 commits into from Jun 27, 2022

Conversation

frenck
Copy link
Member

@frenck frenck commented Jun 27, 2022

This reverts commit 164eba7.

Proposed change

Partially reverts #73872 to address the CI segfault issues we have been running into for the past 5 days.

I've been able to reproduce it locally by creating a fresh venv with a full install of dependencies and running a partial test, like so:

pytest  --timeout=10 --cov=homeassistant.components.open_meteo --cov-report term-missing --cov-report xml:cov.xml --durations=0 --durations-min=0.5 tests/components/open_meteo
[1]    210018 segmentation fault (core dumped)  pytest --timeout=10 --cov=homeassistant.components.open_meteo --cov-report   

Resulting backtrace from the core dump:

Reading symbols from /home/frenck/.pyenv/versions/3.9.9/envs/home-assistant-core/bin/python3.9...
[New LWP 210018]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/home/frenck/.pyenv/versions/3.9.9/envs/home-assistant-core/bin/python3.9 /home'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x000055a2ec81e5d4 in _Py_Dealloc (op=0x55a2eed919c0) at Objects/object.c:2209
2209    Objects/object.c: No such file or directory.

I was able to git bisect it, resulting in:

image

Testing it in draft/testing PR #74046 showed it resolved the segfault in our CI too.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck frenck requested a review from a team as a code owner June 27, 2022 22:00
@probot-home-assistant probot-home-assistant bot added bugfix core small-pr PRs with less than 30 lines. labels Jun 27, 2022
@project-bot project-bot bot added this to Needs review in Dev Jun 27, 2022
Dev automation moved this from Needs review to Reviewer approved Jun 27, 2022
@frenck frenck merged commit 21b842c into dev Jun 27, 2022
@frenck frenck deleted the frenck-2022-1314 branch June 27, 2022 22:48
Dev automation moved this from Reviewer approved to Done Jun 27, 2022
@bdraco bdraco mentioned this pull request Jun 28, 2022
22 tasks
bdraco added a commit to bdraco/home-assistant that referenced this pull request Jun 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed core small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants