Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump satel_integra to 0.3.7 to fix compat with python 3.10 #74543

Merged
merged 1 commit into from Jul 7, 2022

Conversation

c-soft
Copy link
Contributor

@c-soft c-soft commented Jul 6, 2022

Proposed change

FIx for Python 3.10 compatibility, as described in the issue #74251.
The fix is just using new version of the library.

c-soft/satel_integra@0.3.4...0.3.7

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description. Link: c-soft/satel_integra@c5b3ed5
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Jul 6, 2022

Thanks for bumping the dependency! Please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.
    This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks 馃憤

@bdraco bdraco changed the title Bump lib version - fix for python 3.10 support Bump satel_integra to 0.3.7 to fix compat with python 3.10 Jul 6, 2022
@c-soft
Copy link
Contributor Author

c-soft commented Jul 6, 2022

Thanks for bumping the dependency! Please update the PR description to contain at least one (or multiple) of the following:

  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

Of course. Even though the version was bumped by 3, there was only one code change, and fairly simple too. The link is here:

c-soft/satel_integra@c5b3ed5

It removes loop argument from call to asyncio.open_connection. The argument was optional and got removed with Python 3.10 - which caused issue with latest release. Issue in question: #74528
Hope that helps!

@bdraco
Copy link
Member

bdraco commented Jul 6, 2022

I added the link to the diff in the opening text, but it looks like the tag didn't get pushed to the repo

@bdraco bdraco added this to the 2022.7.1 milestone Jul 6, 2022
@c-soft
Copy link
Contributor Author

c-soft commented Jul 6, 2022

Indeed! Thanks for spotting that. Fixed.

Dev automation moved this from Needs review to Reviewer approved Jul 6, 2022
@bdraco
Copy link
Member

bdraco commented Jul 6, 2022

Thanks @c-soft

@bdraco bdraco merged commit fef7893 into home-assistant:dev Jul 7, 2022
Dev automation moved this from Reviewer approved to Done Jul 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

new version breaks satel_integra integration
4 participants