Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify the active ZHA coordinator device in API responses #74739

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Jul 8, 2022

Breaking change

No.

Proposed change

Users who switch coordinators but keep their zigbee.db will be stuck with a stale coordinator entry for their old hardware that cannot be deleted from the frontend.

This change adds the necessary key to the device API response for the frontend to distinguish between the currently coordinator and old coordinators.

I've also added myself as a ZHA code owner.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Dev automation moved this from Needs review to Reviewer approved Jul 8, 2022
@puddly puddly force-pushed the puddly/zha-allow-deleting-stale-coordinator branch 2 times, most recently from bfa0a7e to c1e126e Compare July 8, 2022 17:49
@puddly puddly force-pushed the puddly/zha-allow-deleting-stale-coordinator branch from c1e126e to 7c86758 Compare July 8, 2022 21:33
@puddly
Copy link
Contributor Author

puddly commented Jul 11, 2022

Looks like the frontend PR got merged first (home-assistant/frontend#13154). This one's ready to go too.

@dmulcahey dmulcahey merged commit 2986a2f into home-assistant:dev Jul 11, 2022
Dev automation moved this from Reviewer approved to Done Jul 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants