New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify the active ZHA coordinator device in API responses #74739
Merged
dmulcahey
merged 4 commits into
home-assistant:dev
from
puddly:puddly/zha-allow-deleting-stale-coordinator
Jul 11, 2022
Merged
Identify the active ZHA coordinator device in API responses #74739
dmulcahey
merged 4 commits into
home-assistant:dev
from
puddly:puddly/zha-allow-deleting-stale-coordinator
Jul 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
has-tests
integration: zha
new-feature
small-pr
PRs with less than 30 lines.
labels
Jul 8, 2022
Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration ( |
9 tasks
dmulcahey
approved these changes
Jul 8, 2022
dmulcahey
reviewed
Jul 8, 2022
puddly
force-pushed
the
puddly/zha-allow-deleting-stale-coordinator
branch
2 times, most recently
from
July 8, 2022 17:49
bfa0a7e
to
c1e126e
Compare
dmulcahey
approved these changes
Jul 8, 2022
puddly
force-pushed
the
puddly/zha-allow-deleting-stale-coordinator
branch
from
July 8, 2022 21:33
c1e126e
to
7c86758
Compare
dmulcahey
approved these changes
Jul 9, 2022
Looks like the frontend PR got merged first (home-assistant/frontend#13154). This one's ready to go too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
No.
Proposed change
Users who switch coordinators but keep their
zigbee.db
will be stuck with a stale coordinator entry for their old hardware that cannot be deleted from the frontend.This change adds the necessary key to the device API response for the frontend to distinguish between the currently coordinator and old coordinators.
I've also added myself as a ZHA code owner.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: