Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bluetooth_le_tracker to use Bleak #75013

Merged
merged 28 commits into from Jul 19, 2022
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 11, 2022

Needs #75381

Proposed change

Update bluetooth_le_tracker to use Bleak

I wanted to keep the change as small as possible so its still a legacy tracker but using Bleak now.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Member Author

bdraco commented Jul 11, 2022

While this change will make it push since we see new devices right away we probably still need a periodic poll of async_discovered_service_info to account for devices that the bluez backend didn't send us updates for since they had no RSSI changes as the legacy trackers rely on time

@bdraco
Copy link
Member Author

bdraco commented Jul 12, 2022

We need some type of common Bluetooth mock so integrations don't actually end up setting up a scanner which won't work since the CI definitely doesn't have Bluetooth

- Breaks this out from the bluetooth integration so
  other integrations can mock out bluetooth

- Blocks home-assistant#75013
@bdraco bdraco mentioned this pull request Jul 12, 2022
23 tasks
@bdraco
Copy link
Member Author

bdraco commented Jul 16, 2022

Looks like this had partial test coverage before. Should add a few more when I don't have so many irons in the fire

@bdraco bdraco marked this pull request as ready for review July 18, 2022 18:23
@MartinHjelmare
Copy link
Member

MartinHjelmare commented Jul 18, 2022

This isn't ready for merge yet, right? The Bluetooth changes is from the other branch, I think.

@bdraco
Copy link
Member Author

bdraco commented Jul 18, 2022

This isn't ready for merge yet, right? The Bluetooth changes is from the other branch, I think.

Right, its got that branch merged into it and needs to be rebased so it gets separated out once the other PR is merged.

@bdraco bdraco merged commit b37f15b into home-assistant:dev Jul 19, 2022
@bdraco bdraco deleted the btle_tracker branch July 19, 2022 00:16
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants