New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aiohomekit to 1.0.0 #75198
Bump aiohomekit to 1.0.0 #75198
Conversation
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
mypy issue is fixed in #75200 |
All my IP devices are working great still on my production installs Will do performance testing shortly to check for regressions |
Turned on all the debug logs and watched the traffic. To validate
|
Started up with devices unplugged and plugged them in to verify they recovered quickly |
Only thing interesting in the profile is the json overhead and its really small. We could use |
Doing py-spys now |
It took so long because its so efficient I was having trouble fixing everything in the profiles and py-spys |
Existing device testing is all good |
Testing TODO:
|
Pair new is failing with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pairing and unpairing is solid now with the last bump
a5c5463
to
f400267
Compare
Bumped to final release tag and rebased on dev |
The run is here https://github.com/home-assistant/core/actions/runs/2673138918 |
Proposed change
This bumps to the latest release of aiohomekit, which includes BLE and CoAP (Thread) support. The 2 new backends are switched off, and the goal of this release is to make sure there are no regressions in the existing IP/HTTP backend. We'll then test and switch on BLE in a follow up PR.
The diff is quite large, but we've already done all the API breaks on the 0.7.x channel, so no HA changes are needed to go along with this (well, subjecting to regression testing).
Jc2k/aiohomekit@0.7.22...1.0.0rc1
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: