Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UniFi Protect unauth handling #75269

Merged
merged 1 commit into from Jul 16, 2022

Conversation

AngellusMortis
Copy link
Contributor

@AngellusMortis AngellusMortis commented Jul 15, 2022

Proposed change

UniFi Protect 2.1.1 seems to sometimes reply with a 401 or 403 when UniFi Protect is just not accessible (so an invalid not authorized error). This adds some retry logic before triggering a reauth flow in HA to verify the error is not transient.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @briis, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (unifiprotect) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Jul 15, 2022
@bdraco bdraco added this to the 2022.7.6 milestone Jul 16, 2022
@bdraco
Copy link
Member

bdraco commented Jul 16, 2022

Tested, no longer getting the spurious auth failures

Dev automation moved this from Needs review to Reviewer approved Jul 16, 2022
@bdraco bdraco merged commit 59c99e0 into home-assistant:dev Jul 16, 2022
Dev automation moved this from Reviewer approved to Done Jul 16, 2022
albertogeniola pushed a commit to albertogeniola/core that referenced this pull request Jul 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2022
@AngellusMortis AngellusMortis deleted the fix-bad-auth branch October 18, 2022 00:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Unifi Protect stopped working after updating protect to 2.1.1
4 participants