Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle (and better log) more AirVisual cloud API errors #75332

Merged
merged 1 commit into from Jul 16, 2022

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Jul 16, 2022

Proposed change

This PR helps the integration know additional pyairvisual exceptions that should trigger a reauth.

Changelog: https://github.com/bachya/pyairvisual/releases/tag/2022.07.0
Diff: bachya/pyairvisual@5.0.9...2022.07.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bachya bachya self-assigned this Jul 16, 2022
@project-bot project-bot bot added this to Needs review in Dev Jul 16, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jul 16, 2022
@bachya bachya added this to the 2022.7.6 milestone Jul 16, 2022
Dev automation moved this from By Code Owner to Reviewer approved Jul 16, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bachya 👍

@bachya bachya merged commit 08d6487 into home-assistant:dev Jul 16, 2022
Dev automation moved this from Reviewer approved to Done Jul 16, 2022
albertogeniola pushed a commit to albertogeniola/core that referenced this pull request Jul 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2022
@bachya bachya deleted the airvisual-reauth-errors branch July 18, 2022 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

AirVisual API key expired, but no prompt for new key
3 participants