Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the OpenALPR Local integration #75810

Merged
merged 2 commits into from Jul 27, 2022
Merged

Deprecate the OpenALPR Local integration #75810

merged 2 commits into from Jul 27, 2022

Conversation

frenck
Copy link
Member

@frenck frenck commented Jul 27, 2022

Proposed change

This PR deprecates the OpenALPR Local integration.
It doesn't work correctly (see history of issue), and has no usage. It also cannot be used on our container-based installations. Therefore it is better for this integration to make it way out.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added deprecation Indicates a breaking change to happen in the future integration: openalpr_local labels Jul 27, 2022
@project-bot project-bot bot added this to Needs review in Dev Jul 27, 2022
@frenck frenck added this to the 2022.8.0b0 milestone Jul 27, 2022
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe skip the tests?

@frenck
Copy link
Member Author

frenck commented Jul 27, 2022

I didn't expect tests for this oldie 馃槃

Anyways, I removed them. As they currently do not hold value nor will they have value for the future.

Dev automation moved this from Needs review to Reviewer approved Jul 27, 2022
@MartinHjelmare MartinHjelmare merged commit 07a433a into dev Jul 27, 2022
Dev automation moved this from Reviewer approved to Done Jul 27, 2022
@MartinHjelmare MartinHjelmare deleted the frenck-2022-1544 branch July 27, 2022 10:52
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed deprecation Indicates a breaking change to happen in the future integration: openalpr_local
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants