Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump AIOAladdinConnect to 0.1.33 #75986

Merged
merged 1 commit into from Jul 31, 2022

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Jul 31, 2022

Proposed change

Bump AIOAladdinConnect to 0.1.33

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Addressed missing await calls
Prevent opening second web socket when already "running"
mkmer/AIOAladdinConnect@0.1.31...0.1.33

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Jul 31, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jul 31, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: Sorry, this review comment was incorrect, the links are there in the additional information section.

Dev automation moved this from By Code Owner to Review in progress Jul 31, 2022
@frenck frenck added this to the 2022.8.0 milestone Jul 31, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅
Restarted one of the failing tests

Dev automation moved this from Review in progress to Reviewer approved Jul 31, 2022
@balloob balloob merged commit 003ee85 into home-assistant:dev Jul 31, 2022
Dev automation moved this from Reviewer approved to Done Jul 31, 2022
balloob pushed a commit that referenced this pull request Jul 31, 2022
@mkmer
Copy link
Contributor Author

mkmer commented Jul 31, 2022

EDIT: Sorry, this review comment was incorrect, the links are there in the additional information section.

I'm sorry - is the link supposed to be in the first section? I'm open to whatever makes it easy for you.

@mkmer mkmer deleted the Bump-aladdin_connect-0.1.33 branch July 31, 2022 22:04
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants