Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add siren checks to pylint plugin #76460

Merged
merged 1 commit into from Aug 9, 2022
Merged

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Aug 8, 2022

Proposed change

Add siren checks to pylint plugin

pylint homeassistant/components/**/siren.py --disable=all --enable=hass_enforce_type_hints

************* Module homeassistant.components.rfxtrx.siren
homeassistant/components/rfxtrx/siren.py:136:4: W7432: Return type should be ['bool', None] in is_on (hass-return-type)
homeassistant/components/rfxtrx/siren.py:140:4: W7431: Argument kwargs should be of type Any in async_turn_on (hass-argument-type)
homeassistant/components/rfxtrx/siren.py:140:4: W7432: Return type should be None in async_turn_on (hass-return-type)
homeassistant/components/rfxtrx/siren.py:187:4: W7432: Return type should be ['bool', None] in is_on (hass-return-type)
homeassistant/components/rfxtrx/siren.py:191:4: W7432: Return type should be None in async_turn_on (hass-return-type)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added code-quality small-pr PRs with less than 30 lines. labels Aug 8, 2022
@project-bot project-bot bot added this to Needs review in Dev Aug 8, 2022
Dev automation moved this from Needs review to Reviewer approved Aug 9, 2022
@balloob balloob merged commit bcdf880 into home-assistant:dev Aug 9, 2022
Dev automation moved this from Reviewer approved to Done Aug 9, 2022
@epenet epenet deleted the pylint-siren branch August 9, 2022 15:53
@epenet
Copy link
Contributor Author

epenet commented Aug 9, 2022

Thanks @balloob
It seems that I mistakenly included both select and siren platforms, but I think that's OK
I closed the corresponding select PR #76439

@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants