New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log not allowed attributes only once in BMW binary sensors #76708
Conversation
Hey there @gerard33, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct the spelling
Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>
Oops, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thnx @rikroe
…ant/core#75802) Allow only known attrs for BMW binary sensors (home-assistant/core#76663) Log not allowed attributes only once in BMW binary sensors ((home-assistant/core#76708)
Proposed change
Following up on #76663, logged warnings on previously unseen attribute keys will now occur only once.
It cannot be done on initialization, because new states can always appear during normal updates, so we have to keep track on which errors we have logged.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: