Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log not allowed attributes only once in BMW binary sensors #76708

Merged
merged 2 commits into from Aug 13, 2022

Conversation

rikroe
Copy link
Contributor

@rikroe rikroe commented Aug 13, 2022

Proposed change

Following up on #76663, logged warnings on previously unseen attribute keys will now occur only once.
It cannot be done on initialization, because new states can always appear during normal updates, so we have to keep track on which errors we have logged.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @gerard33, mind taking a look at this pull request as it has been labeled with an integration (bmw_connected_drive) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the spelling

Dev automation moved this from Needs review to Review in progress Aug 13, 2022
Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>
@rikroe
Copy link
Contributor Author

rikroe commented Aug 13, 2022

Oops, thanks!

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thnx @rikroe

Dev automation moved this from Review in progress to Reviewer approved Aug 13, 2022
@jbouwh jbouwh changed the title Log not allowed attrs only once in BMW binary sensors Log not allowed attributes only once in BMW binary sensors Aug 13, 2022
@jbouwh jbouwh merged commit a70252a into home-assistant:dev Aug 13, 2022
Dev automation moved this from Reviewer approved to Done Aug 13, 2022
rikroe added a commit to bimmerconnected/ha_custom_component that referenced this pull request Aug 14, 2022
…ant/core#75802)

Allow only known attrs for BMW binary sensors (home-assistant/core#76663)
Log not allowed attributes only once in BMW binary sensors ((home-assistant/core#76708)
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2022
@rikroe rikroe deleted the bmw-message-attributes branch December 21, 2023 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants