Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screen on/off switch to Fully Kiosk Browser integration #76957

Merged
merged 1 commit into from Aug 18, 2022

Conversation

cgarwood
Copy link
Member

@cgarwood cgarwood commented Aug 17, 2022

Proposed change

Add a switch entity to toggle the device screen on/off.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Aug 17, 2022
@frenck frenck self-requested a review August 18, 2022 09:07
Dev automation moved this from Needs review to Review in progress Aug 18, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works like a charm. ✅

Needs a docs update.

Dev automation moved this from Review in progress to Reviewer approved Aug 18, 2022
@cgarwood
Copy link
Member Author

Docs PR submitted 👍

@frenck frenck merged commit 1aef60c into home-assistant:dev Aug 18, 2022
Dev automation moved this from Reviewer approved to Done Aug 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2022
@cgarwood cgarwood deleted the fullykiosk_screen_switch branch November 2, 2023 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants