Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'sender' as requirement for the config (fixes #7698) #7706

Merged
merged 1 commit into from May 22, 2017
Merged

Make 'sender' as requirement for the config (fixes #7698) #7706

merged 1 commit into from May 22, 2017

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 22, 2017

Description:

Make 'sender' as requirement for the configuration. Instead of catching the exception by smtplib.

Related issue (if applicable): fixes #7698

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2686

Example entry for configuration.yaml (if applicable):

notify:
  - platform: smtp
    name: smtp
    server: !secret ha_email_server
    sender: !secret ha_email_sender
    sender_name: 'asdfasdfsadf'
    port: !secret ha_email_port
    starttls: 1
    username: !secret ha_email_username
    password: !secret ha_email
    recipient:
      - test0@fabian-affolter.ch
      - test1@fabian-affolter.ch

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link

@fabaff, thanks for your PR! By analyzing the history of the files in this pull request, we identified @partofthething, @pvizeli and @azogue to be potential reviewers.

Copy link
Member

@azogue azogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvizeli pvizeli merged commit 783abc7 into home-assistant:dev May 22, 2017
@balloob balloob mentioned this pull request Jun 2, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Sep 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SMTP variable "sender" is mandatory
5 participants