testing pydantic v1.10.0a1 #77246
testing pydantic v1.10.0a1 #77246
Conversation
|
Hi @samuelcolvin, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
| @@ -117,7 +117,7 @@ backoff<2.0 | |||
|
|
|||
| # Breaking change in version | |||
| # https://github.com/samuelcolvin/pydantic/issues/4092 | |||
| pydantic!=1.9.1 | |||
| pydantic=1.10.0a1 | |||
There was a problem hiding this comment.
This is not perse testing it?
It just loosens a constrain, but doesn't install this particular version?
So unless, a package we use installs 1.10.0a1 in their requirements, nothing will happen.
Please note, Home Assistant doesn't directly use pydantic, some of our dependencies do.
There was a problem hiding this comment.
(I've corrected the constraint)
It looks like SystemBridgeCoordinatorData is the only pydantic model in this repo.
If you think there's no value in running these tests, feel free to close this.
If dependants of this repo use pydantic, I'll try to test them directly, but if dependencies use pydantic, running these tests would be good if possible.
There was a problem hiding this comment.
SystemBridgeCoordinatorData
Hmm, that seems incorrect / a bug, as that integration doesn't specify having a dependency on pedantic.
If you think there's no value in running these tests, feel free to close this.
It was not a question about value :) I was a question about this not doing what you probably expected it would do; which is running our test suite against pydantic 1.10.0a1.
There was a problem hiding this comment.
Okay, in that case close this.
By the way, it's probably worth excluding pydantic>2 since pydantic V2 will break a lot of things.
There was a problem hiding this comment.
That is up to the dependencies to handle correctly. We only add constraints when needed and have no better way out.
|
Hi @samuelcolvin, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
TO NOT MERGE
This is pull request is just to test pydantic v1.10, see pydantic/pydantic#4359