Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LED BLE integration #77489

Merged
merged 35 commits into from Aug 29, 2022
Merged

Add LED BLE integration #77489

merged 35 commits into from Aug 29, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 29, 2022

Proposed change

Add LED BLE integration

These devices have been sold under many brands, including:

  • LED BLE
  • BLE-LED
  • Triones
  • Happy Lighting
  • Zengee
  • LEDBlue
  • Zerproc

This integration has the goal of fixing many of the non-functional older bluetooth integrations since they all speak the same protocol under the hood.

The end goal is this should support all the devices that: zengge, zerproc, and https://github.com/sysofwan/ha-triones currently support

This is an MVP and it will not be feature complete for a few versions because the protocol is not documented and has to be reverse engineered with user feedback and testing. I only have 3 of these devices to test with. Once I'm happy with it, I will add repairs issue to deprecate the previous integrations.

I plan on adding these as supported brands in the future once I have a few more of the devices in hand. ... Aliexpress shipping is slow

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco marked this pull request as ready for review August 29, 2022 15:09
{ "local_name": "Triones*" },
{ "local_name": "LEDBlue*" }
],
"iot_class": "local_polling"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan on adding these as supported brands in the future once I have a few more of the devices in hand. ... Aliexpress shipping is slow

bdraco and others added 2 commits August 29, 2022 10:25
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Dev automation moved this from Needs review to Reviewer approved Aug 29, 2022
@bdraco bdraco merged commit 8e0c26b into home-assistant:dev Aug 29, 2022
Dev automation moved this from Reviewer approved to Done Aug 29, 2022
@bdraco bdraco deleted the ledble branch August 29, 2022 16:38
@bdraco
Copy link
Member Author

bdraco commented Aug 29, 2022

Thanks

@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants