New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start logbook stream faster #77921
Start logbook stream faster #77921
Conversation
Since the frontend now handles out of order data we can avoid waiting for the recorder to sync and we can start sending data right away
Since the frontend now handles out of order data we can avoid waiting for the recorder to sync and we can start sending data right away
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Will come back to this after release and any mop up |
Everything works well. The tests are a bit tricky to fix since the time the data arrives is no longer deterministic |
Unfortunately testing this is turning out to be quite difficult since messages get delivered in any order as soon as they are ready. |
Uncovered lines are not from this PR, but let's try one more time to get a clean CI run before merging |
TODO
Proposed change
Since the frontend now handles out of order data we can avoid waiting
for the recorder to sync and we can start sending data right away.
The long term goal is to be able to increase the commit interval
without it being noticeable on the frontend. To make that work
we also need
cc @agners since you asked about this
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: