Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start logbook stream faster #77921

Merged
merged 16 commits into from Sep 9, 2022
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 6, 2022

TODO

  • Adjust the tests since the data can come in any order now (there will be a lot of them)

Proposed change

Since the frontend now handles out of order data we can avoid waiting
for the recorder to sync and we can start sending data right away.

The long term goal is to be able to increase the commit interval
without it being noticeable on the frontend. To make that work
we also need

  • Streaming history
  • History Stats to be aware of the commit interval (this is already a problem which will be worse)

cc @agners since you asked about this

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

Since the frontend now handles out of order data we can avoid waiting
for the recorder to sync and we can start sending data right away
Since the frontend now handles out of order data we can avoid waiting
for the recorder to sync and we can start sending data right away
@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (logbook) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Sep 6, 2022
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Dev automation moved this from Needs review to Reviewer approved Sep 7, 2022
@bdraco
Copy link
Member Author

bdraco commented Sep 7, 2022

Will come back to this after release and any mop up

@bdraco
Copy link
Member Author

bdraco commented Sep 7, 2022

Everything works well. The tests are a bit tricky to fix since the time the data arrives is no longer deterministic

@bdraco
Copy link
Member Author

bdraco commented Sep 8, 2022

Unfortunately testing this is turning out to be quite difficult since messages get delivered in any order as soon as they are ready.

@bdraco
Copy link
Member Author

bdraco commented Sep 9, 2022

Uncovered lines are not from this PR, but let's try one more time to get a clean CI run before merging

@bdraco bdraco marked this pull request as ready for review September 9, 2022 18:51
@bdraco bdraco requested a review from a team as a code owner September 9, 2022 18:51
@bdraco bdraco merged commit fcb6888 into home-assistant:dev Sep 9, 2022
Dev automation moved this from Reviewer approved to Done Sep 9, 2022
@bdraco bdraco deleted the logbook_no_delay branch September 9, 2022 22:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants