New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve type hints in apple_tv media player #77940
Conversation
Hey there @postlund, mind taking a look at this pull request as it has been labeled with an integration ( |
MEDIA_TYPE_APP, | ||
MEDIA_TYPE_APPS, | ||
) | ||
from homeassistant.components.media_player import BrowseMedia, MediaClass, MediaType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like MediaClass
isn't imported in media_player.__init__
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to rebase over the cast PR. Since that PR is delayed I have added it here (shouldn't cause a conflict).
Proposed change
Improve type hints in apple_tv media player
As draft until #77941 is confirmedType of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: