Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type hints in apple_tv media player #77940

Merged
merged 8 commits into from Sep 8, 2022
Merged

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Sep 7, 2022

Proposed change

Improve type hints in apple_tv media player

As draft until #77941 is confirmed

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @postlund, mind taking a look at this pull request as it has been labeled with an integration (apple_tv) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet epenet marked this pull request as draft September 7, 2022 08:36
@epenet epenet marked this pull request as ready for review September 7, 2022 14:37
Dev automation moved this from Needs review to Review in progress Sep 7, 2022
@epenet epenet marked this pull request as draft September 8, 2022 05:34
MEDIA_TYPE_APP,
MEDIA_TYPE_APPS,
)
from homeassistant.components.media_player import BrowseMedia, MediaClass, MediaType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like MediaClass isn't imported in media_player.__init__.

Copy link
Contributor Author

@epenet epenet Sep 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to rebase over the cast PR. Since that PR is delayed I have added it here (shouldn't cause a conflict).

homeassistant/components/apple_tv/browse_media.py Outdated Show resolved Hide resolved
@epenet epenet marked this pull request as ready for review September 8, 2022 08:08
@epenet epenet requested a review from a team as a code owner September 8, 2022 08:08
Dev automation moved this from Review in progress to Reviewer approved Sep 8, 2022
@cdce8p cdce8p merged commit 5276d84 into home-assistant:dev Sep 8, 2022
Dev automation moved this from Reviewer approved to Done Sep 8, 2022
@epenet epenet deleted the apple_tv branch September 8, 2022 08:48
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants