Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new media player enums in forked_daapd #78100

Merged
merged 1 commit into from Sep 13, 2022

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Sep 9, 2022

Proposed change

Use new media player enums in forked_daapd

Currently blocking #78014 and #77937

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @uvjustin, mind taking a look at this pull request as it has been labeled with an integration (forked_daapd) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@uvjustin
Copy link
Contributor

uvjustin commented Sep 9, 2022

I have #77744 open. Let's work on merging that one first.

@epenet epenet marked this pull request as draft September 9, 2022 06:03
@epenet
Copy link
Contributor Author

epenet commented Sep 9, 2022

I have #77744 open. Let's work on merging that one first.

No problem! I've marked it as draft. Sadly I don't feel competent enough to review #77744

@epenet epenet marked this pull request as ready for review September 13, 2022 05:33
@epenet
Copy link
Contributor Author

epenet commented Sep 13, 2022

I have #77744 open. Let's work on merging that one first.

No problem! I've marked it as draft. Sadly I don't feel competent enough to review #77744

I'vea marked is as ready again. It is the last one blocking #77937
https://github.com/home-assistant/core/actions/runs/3042398890/jobs/4900546323

Copy link
Contributor

@uvjustin uvjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's just merge this one first then. I'll rebase the other one.

Can you help me have a look at the other one? I have a few more follow on PRs that I would like to get in before the next release else they get stuck in the Hacktoberfest backlog. It's actually quite simple. I'll mark up the changes.

@epenet
Copy link
Contributor Author

epenet commented Sep 13, 2022

Thanks @uvjustin 馃憤

@epenet epenet merged commit 52ea999 into home-assistant:dev Sep 13, 2022
@epenet epenet deleted the forked_daapd branch September 13, 2022 09:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants