Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cover platform for switchbee integration #78383

Merged
merged 25 commits into from Sep 29, 2022

Conversation

jafar-atili
Copy link
Contributor

@jafar-atili jafar-atili commented Sep 13, 2022

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title Added Platform cover for switchbee integration Add cover platform for switchbee integration Sep 13, 2022
@jafar-atili
Copy link
Contributor Author

I am converting this one to a Draft due to @frenck comments on the Parent PR #70201

Once the Parent PR is approved I will re-open this with the relevant fixes.

homeassistant/components/switchbee/cover.py Outdated Show resolved Hide resolved
homeassistant/components/switchbee/cover.py Outdated Show resolved Hide resolved
homeassistant/components/switchbee/cover.py Outdated Show resolved Hide resolved
homeassistant/components/switchbee/cover.py Outdated Show resolved Hide resolved
homeassistant/components/switchbee/cover.py Outdated Show resolved Hide resolved
@epenet
Copy link
Contributor

epenet commented Sep 28, 2022

Rebased over #78583

@jafar-atili jafar-atili marked this pull request as ready for review September 28, 2022 16:19
homeassistant/components/switchbee/cover.py Outdated Show resolved Hide resolved
homeassistant/components/switchbee/cover.py Outdated Show resolved Hide resolved
homeassistant/components/switchbee/cover.py Outdated Show resolved Hide resolved
homeassistant/components/switchbee/cover.py Outdated Show resolved Hide resolved
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
homeassistant/components/switchbee/cover.py Outdated Show resolved Hide resolved
homeassistant/components/switchbee/cover.py Outdated Show resolved Hide resolved
homeassistant/components/switchbee/cover.py Outdated Show resolved Hide resolved
homeassistant/components/switchbee/cover.py Outdated Show resolved Hide resolved
homeassistant/components/switchbee/cover.py Outdated Show resolved Hide resolved
homeassistant/components/switchbee/cover.py Outdated Show resolved Hide resolved
homeassistant/components/switchbee/cover.py Outdated Show resolved Hide resolved
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epenet epenet merged commit 75510b8 into home-assistant:dev Sep 29, 2022
@jafar-atili
Copy link
Contributor Author

Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants