New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for controlling manual watering time on Melnor Bluetooth devices #78653
Merged
bdraco
merged 5 commits into
home-assistant:dev
from
vanstinator:feature/melnor-minutes
Sep 19, 2022
Merged
Add support for controlling manual watering time on Melnor Bluetooth devices #78653
bdraco
merged 5 commits into
home-assistant:dev
from
vanstinator:feature/melnor-minutes
Sep 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanstinator
changed the title
Bump melnor-bluetooth to v0.0.19
Add support for controlling manual watering time on Melnor Bluetooth devices
Sep 17, 2022
8 tasks
vanstinator
force-pushed
the
feature/melnor-minutes
branch
from
September 17, 2022 23:36
ba70eaa
to
ebefece
Compare
vanstinator
force-pushed
the
feature/melnor-minutes
branch
from
September 17, 2022 23:37
ebefece
to
69e5c6a
Compare
vanstinator
commented
Sep 17, 2022
bdraco
reviewed
Sep 18, 2022
bdraco
reviewed
Sep 18, 2022
bdraco
reviewed
Sep 18, 2022
bdraco
reviewed
Sep 18, 2022
The consolidation is done. Much better! |
bdraco
reviewed
Sep 19, 2022
bdraco
approved these changes
Sep 19, 2022
Thanks @vanstinator Note that the docs may need some tweaks |
I added the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adding the first set of new smarts to the Melnor Bluetooth integration. Today the integration is quite simple. It allows a user to turn valves on and off. There's no ability to control the device's watering length without dropping back down to the app (after disconnecting the device from HA 😬) and tweaking the value. Exposing the ability to change and monitor the manual watering runtime is a huge QoL improvement.
I've added 2 pieces of functionality to support this feature:
number
platform to expose entities allowing the user to enter the value that we send to the device indicating how long it should run each time the valve is turned on. The HA device page ends up being a really great UI with these enabled.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: