Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for controlling manual watering time on Melnor Bluetooth devices #78653

Merged
merged 5 commits into from Sep 19, 2022

Conversation

vanstinator
Copy link
Contributor

@vanstinator vanstinator commented Sep 17, 2022

Proposed change

Adding the first set of new smarts to the Melnor Bluetooth integration. Today the integration is quite simple. It allows a user to turn valves on and off. There's no ability to control the device's watering length without dropping back down to the app (after disconnecting the device from HA 😬) and tweaking the value. Exposing the ability to change and monitor the manual watering runtime is a huge QoL improvement.

I've added 2 pieces of functionality to support this feature:

  • a new sensor to expose the remaining time left for a zone.
  • support for the number platform to expose entities allowing the user to enter the value that we send to the device indicating how long it should run each time the valve is turned on. The HA device page ends up being a really great UI with these enabled.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Sep 17, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Sep 17, 2022
@vanstinator vanstinator changed the title Bump melnor-bluetooth to v0.0.19 Add support for controlling manual watering time on Melnor Bluetooth devices Sep 17, 2022
@vanstinator vanstinator marked this pull request as ready for review September 17, 2022 23:41
@vanstinator
Copy link
Contributor Author

The consolidation is done. Much better!

Dev automation moved this from By Code Owner to Reviewer approved Sep 19, 2022
@bdraco
Copy link
Member

bdraco commented Sep 19, 2022

Thanks @vanstinator

Note that the docs may need some tweaks

@vanstinator
Copy link
Contributor Author

vanstinator commented Sep 19, 2022

I added the number platform to the docs already. The docs were otherwise quite sparse as user setup is a breeze.

@bdraco bdraco merged commit 3eab4a2 into home-assistant:dev Sep 19, 2022
Dev automation moved this from Reviewer approved to Done Sep 19, 2022
@vanstinator vanstinator deleted the feature/melnor-minutes branch September 19, 2022 11:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants