Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple files properly in zwave_js update entity #78658

Merged
merged 6 commits into from Sep 18, 2022

Conversation

raman325
Copy link
Contributor

Proposed change

Onto PR 7 related to the update entity, continuing to fix bugs 🙂 hopefully 7th times a charm.

Discovered that the asyncio.Event logic does not handle multiple files because we don't reset the event after waiting for it the first time. Resetting the flag should cause the service to block until the second file is done.

For some reason the new test hangs though and I can't figure out where it is blocking. Would appreciate some guidance

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@raman325 raman325 added this to the 2022.9.5 milestone Sep 17, 2022
@project-bot project-bot bot added this to Needs review in Dev Sep 17, 2022
@probot-home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@raman325 raman325 marked this pull request as ready for review September 18, 2022 09:58
@raman325 raman325 requested a review from a team as a code owner September 18, 2022 09:58
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Dev automation moved this from Needs review to Reviewer approved Sep 18, 2022
@MartinHjelmare MartinHjelmare merged commit 4d61516 into home-assistant:dev Sep 18, 2022
Dev automation moved this from Reviewer approved to Done Sep 18, 2022
@raman325 raman325 deleted the multiple branch September 18, 2022 16:08
balloob pushed a commit that referenced this pull request Sep 18, 2022
* Handle multiple files properly in zwave_js update entity

* Until we have progress, set in progress to true. And fix when we write state

* fix tests

* Assert we set in progress to true before we get progress

* Fix tests

* Comment
@balloob balloob mentioned this pull request Sep 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants