Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trafikverket Camera integration #79873

Merged
merged 27 commits into from Aug 24, 2023
Merged

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Oct 8, 2022

Proposed change

Introduce the Trafikverket Camera integration

Needs

  • tests
  • brand
  • doc's

Requires #79872

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Contributor

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick remarks/code improvements, hopefully it is helpful. Great to see so many tests by the way!

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 28, 2023
@gjohansson-ST
Copy link
Member Author

Not stale. Awaiting review.

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the CI?

homeassistant/components/trafikverket_camera/camera.py Outdated Show resolved Hide resolved
homeassistant/components/trafikverket_camera/camera.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft August 16, 2023 09:08
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@gjohansson-ST gjohansson-ST marked this pull request as ready for review August 16, 2023 20:05
@home-assistant home-assistant bot requested a review from edenhaus August 16, 2023 20:05
@gjohansson-ST gjohansson-ST marked this pull request as draft August 17, 2023 06:36
@gjohansson-ST gjohansson-ST marked this pull request as ready for review August 17, 2023 18:48
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small findings and then we are ready to merge 🥳

@home-assistant home-assistant bot marked this pull request as draft August 23, 2023 16:54
@gjohansson-ST gjohansson-ST marked this pull request as ready for review August 23, 2023 18:30
@home-assistant home-assistant bot requested a review from edenhaus August 23, 2023 18:30
@gjohansson-ST
Copy link
Member Author

Test failure not related to this PR

@gjohansson-ST gjohansson-ST added the smash Indicator this PR is close to finish for merging or closing label Aug 23, 2023
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gjohansson-ST 🚀

@edenhaus edenhaus merged commit 147351b into home-assistant:dev Aug 24, 2023
34 checks passed
@gjohansson-ST gjohansson-ST deleted the tvcamera branch August 24, 2023 09:52
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants