Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensor platform to LaMetric #79935

Merged
merged 3 commits into from Oct 9, 2022
Merged

Add sensor platform to LaMetric #79935

merged 3 commits into from Oct 9, 2022

Conversation

frenck
Copy link
Member

@frenck frenck commented Oct 9, 2022

Proposed change

Add the initial sensor platform to the LaMetric integration.
Currently, a single (disabled by default) Wi-Fi signal sensor has been added + tests.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hey there @robbiet480, @bachya, mind taking a look at this pull request as it has been labeled with an integration (lametric) you are listed as a code owner for? Thanks!

@bachya
Copy link
Contributor

bachya commented Oct 9, 2022

Can confirm that functionally, this PR works. By default, the newly-created sensor is disabled:

CleanShot 2022-10-09 at 10 20 24@2x

After enabling it, it successfully receives data upon coordinator update:

CleanShot 2022-10-09 at 10 21 40@2x

@frenck
Copy link
Member Author

frenck commented Oct 9, 2022

Meh missed that, mainly caused by: the new entity naming style is not my personally used naming style 馃槅

Will address this.

Co-authored-by: Aaron Bach <bachya1208@gmail.com>
@frenck frenck requested a review from bachya October 9, 2022 19:07
Copy link
Contributor

@bachya bachya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤馃徎

@frenck frenck merged commit 5a0609a into dev Oct 9, 2022
@frenck frenck deleted the frenck-2022-1890 branch October 9, 2022 19:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants