New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sensor platform to LaMetric #79935
Conversation
Hey there @robbiet480, @bachya, mind taking a look at this pull request as it has been labeled with an integration ( |
Meh missed that, mainly caused by: the new entity naming style is not my personally used naming style 馃槅 Will address this. |
Co-authored-by: Aaron Bach <bachya1208@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 馃憤馃徎
Proposed change
Add the initial sensor platform to the LaMetric integration.
Currently, a single (disabled by default) Wi-Fi signal sensor has been added + tests.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: