Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Shelly Plus Addon sensors #79954

Merged
merged 1 commit into from Oct 15, 2022

Conversation

thecode
Copy link
Member

@thecode thecode commented Oct 9, 2022

Proposed change

Add support for Shelly Plus Addon sensors:

  • Temperature and Humidity (DHT22)
  • Temperature (DS18B20)
  • Analog Input (percentage)
  • Voltmeter

I have tested all sensors except DHT22, according to the API this is identical to the sensors of the Shelly Plus H&T (which we already create and the temperature sensor of the DS18B20.

image

Previously we assumed devices will have maximum of 4 channels (hardcoded), these sensors starts from 100, so I have changed the logic to search for keys to support that, not breaking anything backward (compared the whole storage of unique ids of my system with several devices before and after)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hey there @balloob, @bieniu, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Copy link
Member

@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the Addon to test the solution but the code looks good.

@thecode
Copy link
Member Author

thecode commented Oct 15, 2022

Thanks!

@thecode thecode merged commit e1520a0 into home-assistant:dev Oct 15, 2022
@thecode thecode deleted the shelly-addon branch October 15, 2022 09:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants