Assemble platforms upfront in devolo Home Network #80126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @2Fake, mind taking a look at this pull request as it has been labeled with an integration ( |
elupus
reviewed
Oct 11, 2022
| @@ -106,7 +110,7 @@ async def disconnect(event: Event) -> None: | |||
| for coordinator in coordinators.values(): | |||
| await coordinator.async_config_entry_first_refresh() | |||
|
|
|||
| await hass.config_entries.async_forward_entry_setups(entry, PLATFORMS) | |||
| hass.config_entries.async_setup_platforms(entry, platforms(device)) | |||
There was a problem hiding this comment.
This should still be the new async_forward_entry_setups call.
There was a problem hiding this comment.
Fixed. This MR was dangling in my personal backlog for quite a while, so it is a good idea to watch out for stuff like this.
Shutgun
force-pushed
the
hn_assemble_platforms
branch
from
c1142cb
to
ae15465
Compare
Shutgun
force-pushed
the
hn_assemble_platforms
branch
from
ae15465
to
45d75ed
Compare
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
It's waiting for review ... |
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
In #72030, @balloob suggested to not load all platforms and check for the capabilities of the device in there but to check the capabilities upfront and then only load suitable platforms. This MR addresses that.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: