New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for area field from pylutron_caseta #80221
Conversation
Hey there @swails, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
For this PR we're still using the name field from pylutron-caseta, and just discarding the area portion before the underscore
The next PR will remove the use of this name field, and build the name from fundamental fields provided by pylutron-caseta. I wanted to keep the PRs more simple, so separating the area updates, from the naming updates. |
Thanks @danaues |
Also, tested on all my systems 馃憤 |
Thanks! |
Proposed change
An area field was introduced in pylutron-caseta 0.16.0
Currently the area is parsed out of the name field provided by the library.
ex. name = "Basement Bedroom_Main Lights"
area is extracted from the text before the underscore, the name after the underscore
This update uses the area field to retrieve the area name from the smartbridge.areas dict.
RA3/HWQSX also supports nested areas. This update will retrieve the full area name from the area tree.
In the below image, the full area name for the Bedroom will be returned as "Basement Bedroom"
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: