Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for area field from pylutron_caseta #80221

Merged
merged 2 commits into from Oct 13, 2022

Conversation

danaues
Copy link
Contributor

@danaues danaues commented Oct 12, 2022

Proposed change

An area field was introduced in pylutron-caseta 0.16.0

Currently the area is parsed out of the name field provided by the library.
ex. name = "Basement Bedroom_Main Lights"
area is extracted from the text before the underscore, the name after the underscore

This update uses the area field to retrieve the area name from the smartbridge.areas dict.

RA3/HWQSX also supports nested areas. This update will retrieve the full area name from the area tree.
In the below image, the full area name for the Bedroom will be returned as "Basement Bedroom"

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hey there @swails, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (lutron_caseta) you are listed as a code owner for? Thanks!

@danaues
Copy link
Contributor Author

danaues commented Oct 12, 2022

For this PR we're still using the name field from pylutron-caseta, and just discarding the area portion before the underscore

name = ha_device["name"].split("_")[-1]

The next PR will remove the use of this name field, and build the name from fundamental fields provided by pylutron-caseta.
That way pylutron-caseta won't be handling any naming of the entities or devices, just passing along the names and id's provided by the processor/bridge. I think it makes sense to have the entity and device names built within the integration, and not the supporting library.

I wanted to keep the PRs more simple, so separating the area updates, from the naming updates.

@bdraco bdraco merged commit 01c66aa into home-assistant:dev Oct 13, 2022
@bdraco
Copy link
Member

bdraco commented Oct 13, 2022

Thanks @danaues

@bdraco
Copy link
Member

bdraco commented Oct 13, 2022

Also, tested on all my systems 馃憤

@danaues
Copy link
Contributor Author

danaues commented Oct 13, 2022

Thanks!

@danaues danaues deleted the lutron_caseta_area_fields branch October 13, 2022 00:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants