New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust distance unit check in waze travel time #80241
Conversation
Hey there @eifinger, mind taking a look at this pull request as it has been labeled with an integration ( |
@@ -63,11 +64,13 @@ async def async_setup_entry( | |||
defaults = { | |||
CONF_REALTIME: DEFAULT_REALTIME, | |||
CONF_VEHICLE_TYPE: DEFAULT_VEHICLE_TYPE, | |||
CONF_UNITS: hass.config.units.name, | |||
CONF_UNITS: UNITS_METRIC, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking/Storing the name
of the unit system will stop working if we rename or add a new unit system.
It is more future-proof to check the length_unit
of the unit system, even if the component still uses "imperial" terminology in the config flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted to use hass.config.units == ***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed change
Adjust distance unit check in waze travel time
Linked to #80257
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: