Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag eafm sensors are measurement to collect long term stats #80312

Merged
merged 4 commits into from Oct 14, 2022
Merged

Tag eafm sensors are measurement to collect long term stats #80312

merged 4 commits into from Oct 14, 2022

Conversation

jfparis
Copy link
Contributor

@jfparis jfparis commented Oct 14, 2022

Proposed change

Added the "state_class: measurement" attributes to the flood monitor sensors provided by the environment agency flood monitor integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Added the "state_class: measurement" attributes to the flood monitor
sensors provided by the environment agency flood monitor integration
@home-assistant
Copy link

Hi jfparis

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @Jc2k, mind taking a look at this pull request as it has been labeled with an integration (eafm) you are listed as a code owner for? Thanks!

@Jc2k
Copy link
Member

Jc2k commented Oct 14, 2022

Can you fix the black/isort errors

@frenck
Copy link
Member

frenck commented Oct 14, 2022

@Jc2k Done

@Jc2k
Copy link
Member

Jc2k commented Oct 14, 2022

Good to merge when the CI gods are happy

@jfparis
Copy link
Contributor Author

jfparis commented Oct 14, 2022

Thank you @frenck
I got there eventually (after installing full dev container) but very slowly.

@frenck
Copy link
Member

frenck commented Oct 14, 2022

No problem @jfparis 👍
I have the dev environment open all day, so this was just a quick thing to solve (and get things moving 🚀 )

@Jc2k
Copy link
Member

Jc2k commented Oct 14, 2022

@frenck how do you switch to PR's out of interest. I'm still a bit of a dinosaur doing git like its 10 years ago or something.

@Jc2k Jc2k merged commit 3840cbd into home-assistant:dev Oct 14, 2022
@frenck
Copy link
Member

frenck commented Oct 14, 2022

@Jc2k Depends on what you are using.

  • You can add the upstream repo as a remote to your git repo and work that way
  • If you have the GitHub CLI installed run gh pr checkout 80312
  • In VSCode, when you have the GitHub extensions installed, hit the command palette and choose: "GitHub Pull Requests: Checkout Pullrequest by Number" and enter the PR number in the next screen.
  • In VSCode, when you have the GitHub extensions installed, open it up in the sidebar of vscode and look at your assigned PRs. You can view them and check them out of review.

Multiple options and routes. I personally most often use the second & third options.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2022
@jfparis jfparis deleted the eafm_statistics branch November 10, 2022 23:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants