Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stream recorder with orientation transforms #80370

Merged
merged 1 commit into from Oct 18, 2022

Conversation

uvjustin
Copy link
Contributor

@uvjustin uvjustin commented Oct 15, 2022

Proposed change

#77439 added orientation transforms to stream by modifying metadata within the moov atom of the mp4/fmp4s. The implementation assumed a fixed byte location of the moov box which is not valid. This PR adds a find_moov function to stream which is similar to the existing find_box function but works on BufferedIOBase objects instead of bytes objects, and it uses this function to find the moov box.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @hunterjm, @allenporter, mind taking a look at this pull request as it has been labeled with an integration (stream) you are listed as a code owner for? Thanks!

@uvjustin uvjustin added this to the 2022.10.5 milestone Oct 15, 2022
@avbor
Copy link

avbor commented Oct 15, 2022

Sorry for ask, but is this change can fix #80080 (specifically, the correctness of the playback of the recorded video in Telegram)?

@franlmc
Copy link

franlmc commented Oct 16, 2022

Sorry for ask, but is this change can fix #80080 (specifically, the correctness of the playback of the recorded video in Telegram)?

I support the request.

@MartinHjelmare MartinHjelmare changed the title Fix stream recorder after #77439 Fix stream recorder with orientation transforms Oct 17, 2022
@balloob balloob merged commit d38d21a into home-assistant:dev Oct 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic camera record service error stream
6 participants