Improve type hints in blebox #80511
Merged
Improve type hints in blebox #80511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
Hacktoberfest
integration: blebox
labels
|
Hey there @bbx-a, @riokuu, mind taking a look at this pull request as it has been labeled with an integration ( |
23 tasks
epenet
added
the
smash
cdce8p
requested changes
Oct 18, 2022
epenet
commented
Oct 18, 2022
| @@ -44,7 +44,7 @@ async def test_setup_failure_on_connection(hass, caplog): | |||
|
|
|||
| async def test_unload_config_entry(hass): | |||
| """Test that unloading works properly.""" | |||
| patch_product_identify(None) | |||
| setup_product_mock("switches", []) | |||
There was a problem hiding this comment.
I had to adjust the test here because product.features was being incorrectly patched as a coroutine.
epenet
removed
the
smash
cdce8p
reviewed
Oct 19, 2022
cdce8p
approved these changes
Oct 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Improve type hints in blebox:
_FeatureTasTypeVarfor bleboxFeaturetypeBleBoxEntitya genericGeneric[_FeatureT]Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: